[Voyage-linux] [PATCH 0/4] voyage-installer: ROOT_FS label --> VOYAGE_FS

[Kim-man 'Punky' TSE]

Hi Jim Cromie,

All 4 patches applied and is available in the voyage-util now.

http://www.voyage.hk/dists/experimental/voyage-util/voyage-util_0.12-2_all.deb

Additional to this patch is setting ROOT_LBL=VOYAGE_FS to format-cf.sh, such that format-cf.sh could be run alone.

Index: overlay_fs/usr/local/sbin/format-cf.sh
===================================================================
--- overlay_fs/usr/local/sbin/format-cf.sh    (revision 373)
+++ overlay_fs/usr/local/sbin/format-cf.sh    (revision 374)
@@ -6,7 +6,8 @@
  DONT_ASK="0"

  if [ -z $ROOT_LBL ] ; then
-    err_quit "ROOT_LBL not set, in $0, quitting"
+#    err_quit "ROOT_LBL not set, in $0, quitting"
+    ROOT_LBL=VOYAGE_FS
  fi

  # no here-document here.
On 9/23/2012 1:19 AM, Jim Cromie wrote:
> Hi Punky,
>
> This patchset changes hardcoded ROOT_FS to $ROOT_LBL, ie VOYAGE_FS.
> The intent is to be sure we've identified the correct device and
> partition before we reformat it (ROOT_FS is too generic to be sure its
> not someone elses).  This allows safer automation of partition
> formatting, unmounting before formatting etc, possibly with less "Are
> you SURE ?" questions.
>
> Its not tested all the way thru to a working CF image; I have great
> trouble getting a bootable image to my my 4gb CF, and Im reluctant
> to sacrifice the working image (daily build 20120814) on my 512mb CF.
>
> So I did the patch in steps, and tested for expected errors.
>      
> 0001-voyage-installer-prep-to-change-ROOT_FS-label-to-VOY.patch
> 0002-voyage-install-set-ROOT_LBL-VOYAGE_FS.patch
> 0003-copyfiles.sh-add-sync-may-not-be-needed-useful.patch
> 0004-voyage-install-guess-target-disk-from-partition-labe.patch
>
>
> So this probably isnt 0.9rc1 material, unless you think the "dont eat
> someone elses lunch" behavior is worth the additional work needed to
> test out the changes right now.
>
>
> _______________________________________________
> Voyage-linux mailing list
> Voyage-linux at list.voyage.hk
> http://list.voyage.hk/mailman/listinfo/voyage-linux


-- 
Regards,
Kim-man "Punky" Tse

* Open Source Embedded Solutions and Systems
   - Voyage Linux (http://linux.voyage.hk)
   - Voyage ONE   (http://linux.voyage.hk/voyage-one)
   - Voyage MPD   (http://linux.voyage.hk/voyage-mpd)
* Voyage Store   (http://store.voyage.hk)